Turn BUILD_TESTING off if EXECUTORCH_BUILD_TESTS is off #12566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12566
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4c2e046 with merge base 4d7f9ca ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Jul 16, 2025
As the comment notes, it looks like otherwise we have third-party deps that might include(CTest) and thereby turn on testing even though our specific option is off. (Should we get rid of the specific option or more directly alias it to BUILD_TESTING?) ghstack-source-id: 50971cb ghstack-comment-id: 3081826265 Pull-Request: #12566
This was referenced Jul 16, 2025
swolchok
added a commit
that referenced
this pull request
Jul 16, 2025
This was referenced Jul 16, 2025
Draft
jathu
reviewed
Jul 17, 2025
CMakeLists.txt
Outdated
Comment on lines
168
to
172
| else() | ||
| # It looks like some of our third-party deps will try to turn this | ||
| # on if it's not explicitly set, leading to confusing behavior. | ||
| set(BUILD_TESTING OFF) | ||
| endif() |
There was a problem hiding this comment.
Can you check how this behaves if you enable tokenizers? It uses abseil, which always includes CTest, which will turn on BUILD_TESTING
There was a problem hiding this comment.
I believe that's the third-party dep I was referring to, and that CTest won't turn on testing if it's already explicitly turned off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment notes, it looks like otherwise we have third-party deps that might include(CTest) and thereby turn on testing even though our specific option is off. (Should we get rid of the specific option or more directly alias it to BUILD_TESTING?)